Fix GH-21058: error_log() crash on null destination argument. #21064
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
reviewed
Jan 29, 2026
|
|
||
| case 3: /*save to a file */ | ||
| stream = php_stream_open_wrapper(ZSTR_VAL(opt), "a", REPORT_ERRORS, NULL); | ||
| stream = php_stream_open_wrapper(opt ? ZSTR_VAL(opt) : NULL, "a", REPORT_ERRORS, NULL); |
Member
There was a problem hiding this comment.
If this is a no-op anyway, then why not check !opt and bail out here? Seems clearer to me
Member
Author
There was a problem hiding this comment.
it s for php_stream_open_wrapper_ex to throws a ValueError which aligns with previous branches.
ndossche
approved these changes
Jan 29, 2026
| error_log("test", 3, null); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage(), PHP_EOL; | ||
| } |
we preserve the lower branches behavior by letting php_stream_open_wrapper_ex handling the null path and propagating the exception. close phpGH-21064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we preserve the lower branches behavior by letting php_stream_open_wrapper_ex handling the null path and propagating the exception.